Repository navigation
Fix(35835) - #36300
Fix(35835)#36300
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Ready for reviewing @allroundexperts 🙏 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-17.at.7.40.12.AM.movAndroid: mWeb ChromeScreen.Recording.2024-02-17.at.7.39.17.AM.moviOS: NativeScreen.Recording.2024-02-17.at.7.38.33.AM.moviOS: mWeb SafariScreen.Recording.2024-02-17.at.7.37.52.AM.movMacOS: Chrome / SafariScreen.Recording.2024-02-17.at.7.35.37.AM.movMacOS: DesktopScreen.Recording.2024-02-17.at.7.36.22.AM.mov |
|
@jeremy-croff I think you uploaded an incorrect screen recording for Android. Can you please check? |
There was a problem hiding this comment.
Why are you removing this comment?
There was a problem hiding this comment.
Oh, I see the reason now. NVM my comment.
There was a problem hiding this comment.
Shouldn't this be called for iOS only?
There was a problem hiding this comment.
I did consider this as well at first
But In this same file, we call this effect in another flow without having any exclusions for the device. And because it's a keyboard-aware effect, it only impacts Native experiences inherently.
Lastly - I confirmed this change improves Android composer show time as well. The original solution was only solving for IOS.
Updated.. thanks for catching it. |
|
Addressed all comments, thanks. |
Thank you, @NikkiWines, for your revision. |
6560694 to
28f9afd
Compare
NikkiWines
left a comment
There was a problem hiding this comment.
thanks for updating. tested and works well ![]()
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|

Details
Fixed Issues
$ #35835
PROPOSAL: #35835 (comment)
Tests
Offline tests
Let's delete the last message while offline
QA Steps
IOS Native tests:
Touch screen tests ( devices with keyboard):
Other device tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2024-02-16_21-10-07.mp4
Android: mWeb Chrome
2024-02-15_19-45-09.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.Web.mp4
MacOS: Chrome / Safari
Web.mp4
MacOS: Desktop
Electron.mp4